update node version and use pnpm #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MinThaMie
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
This technically looks good, the update to style guide 11 breaks Percy, but I think we can be fine with that for now.
To solve two options -> move the link icon to the back of the title as in all the other apps, ignore the margin in our custom css
And we should at some point discuss the behaviour of this, because I think the paragraph icon currently does not reveal more info, so I'm not sure what that behaviour is about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.